Add distribution_url property to override download URL
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Adds a `distribution_url` property to the action, which overrides the download URL unconditionally. It is up to the caller to provide an archive which works on their Github Actions runner; there is no way (at this time) to vary the distribution URL by architecture or OS. - feat: add `distribution_url` input option - feat: honor `distribution_url` in all branches - chore: update docs with `distribution_url` info Fixes and closes graalvm#60 Signed-off-by: Sam Gammon <[email protected]>
sgammon
force-pushed
the
fix/issue-60
branch
from
4f805f7 to
0711c08
Compare
sgammon
added a commit
to elide-dev/elide
that referenced
this pull request
Sep 13, 2023
sgammon
added a commit
to elide-dev/elide
that referenced
this pull request
Sep 14, 2023
sgammon
added a commit
to elide-dev/elide
that referenced
this pull request
Sep 18, 2023
sgammon
added a commit
to elide-dev/elide
that referenced
this pull request
Sep 19, 2023
sgammon
added a commit
to elide-dev/elide
that referenced
this pull request
Sep 19, 2023
fniephaus
reviewed
Sep 20, 2023
| @@ -45,10 +46,10 @@ async function run(): Promise<void> { | |||
| if (isGraalVMforJDK17OrLater) { | |||
| switch (distribution) { | |||
| case c.DISTRIBUTION_GRAALVM: | |||
| graalVMHome = await graalvm.setUpGraalVMJDK(javaVersion) | |||
| graalVMHome = await graalvm.setUpGraalVMJDK(javaVersion, customDistributionUrl) | |||
There was a problem hiding this comment.
Instead of letting customDistributionUrl creep into all these setUp functions, I'd prefer if we handle customDistributionUrl.length > 0 in one place. What do you think?
|
Is this still something that you need, @sgammon?
Given the current limitations, I wonder how useful this is. |
|
@fniephaus This is no longer something we need, no :) also, I think new properties were added for custom SDK versions (GVM EA in particular), so we are good to go. Thanks for the bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
distribution_urlproperty to the action, which overrides the download URL unconditionally. It is up to the caller to provide an archive which works on their Github Actions runner; there is no way (at this time) to vary the distribution URL by architecture or OS.distribution_urlinput optiondistribution_urlin all branchesdistribution_urlinfoFixes and closes #60.