-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve GraalVM version check. #646
Conversation
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
I made the OCA request, but it is still "under review" since 03.12.2024. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the OCA request, but it is still "under review" since 03.12.2024.
- @oracle-contributor-agreement 's github bot cannot automatically detect whether the OCA has been signed, you need to push the PR again.
- To be honest, I don't know where to report bugs around @oracle-contributor-agreement . And there are not many places where @oracle-contributor-agreement can be used.
Thank you for signing the OCA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Fix for Issue #644
Building a native image with "non Oracle" GraalVM fails with the following error.
The problem was a regular expression.
And for reference, here is the version reported by our native-image: