task: fix example app xcode 15 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-gr4vy
commented
Nov 28, 2024
| @@ -80,6 +80,5 @@ | |||
| }, | |||
| "engines": { | |||
| "node": ">= 16.0.0" | |||
| }, | |||
There was a problem hiding this comment.
That restriction should have been removed
gryevns
approved these changes
Nov 28, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: We aren't able to build and run the example app in Xcode 15+ due to a Pods error. Long-term solution should be to upgrade to the latest
react-nativepackage version, but in the meantime we can apply this fix. Upgrade will be tackled in a separate ticket https://gr4vy.atlassian.net/browse/TA-9479.Tested, works well both building and running with Xcode and through the cli command.
Ticket: https://gr4vy.atlassian.net/browse/TA-6984