task: add support for cart items #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-gr4vy
added
minor
luca-gr4vy
commented
Jun 26, 2024
android/src/main/java/com/gr4vy/embedreactnative/EmbedReactNativeModule.java
Outdated
Show resolved
Hide resolved
luca-gr4vy
commented
Jun 26, 2024
ios/EmbedReactNative.swift
Outdated
Comment on lines
184
to
185
| let discountAmount = dict["discountAmount"] as? Int ?? 0 | ||
| let taxAmount = dict["taxAmount"] as? Int ?? 0 |
There was a problem hiding this comment.
This is waiting for the type update in the iOS SDK https://github.com/gr4vy/gr4vy-ios/blob/main/gr4vy-iOS/Models/Gr4vyCartItem.swift. We don't want to pass a default of 0 as this would cause a mismatch between the passed prop and the value in the JWT if people don't pass anything
luca-gr4vy
commented
Jun 26, 2024
| @@ -29,6 +29,8 @@ | |||
| }, | |||
| "resolutions": { | |||
| "braces": "^3.0.3", | |||
| "tar": "^6.2.1" | |||
| "tar": "^6.2.1", | |||
| "ws": "^7.5.10", | |||
There was a problem hiding this comment.
Fix ws vulnerability
luca-gr4vy
commented
Jun 26, 2024
| @@ -61,6 +66,25 @@ public static <T> T coalesce(T... items) { | |||
| return null; | |||
| } | |||
|
|
|||
| public static Object getMapOptionalValue(ReadableMap map, String key) { | |||
There was a problem hiding this comment.
ReadableMap doesn't seem to have a method to get options values and fallback to null, so adding one here
gryevns
reviewed
Jun 26, 2024
android/src/main/java/com/gr4vy/embedreactnative/EmbedReactNativeModule.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/gr4vy/embedreactnative/EmbedReactNativeModule.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/gr4vy/embedreactnative/EmbedReactNativeModule.java
Show resolved
Hide resolved
android/src/main/java/com/gr4vy/embedreactnative/EmbedReactNativeModule.java
Outdated
Show resolved
Hide resolved
luca-gr4vy
commented
Jun 27, 2024
| @@ -311,7 +333,7 @@ class EmbedReactNative: NSObject { | |||
| ] | |||
| ) | |||
| return | |||
| case .transactionCreated(let transactionID, let status, let paymentMethodID): | |||
| case .transactionCreated(let transactionID, let status, let paymentMethodID, let approvalUrl): | |||
There was a problem hiding this comment.
This is needed by the latest update otherwise the build fails gr4vy/gr4vy-ios#10
victormferrara
approved these changes
Jul 1, 2024
luca-gr4vy
deleted the
task/TA-7501-add-support-for-connection-options-and-cart-items
branch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adds support for the missing
cartItemsproperties:discountAmount,taxAmount,externalIdentifier,sku,productUrl,imageUrl,categoriesandproductType.Tested locally with simulators, the values appear in the transaction response and on dashboard.
Note: the iOS part requires this
gr4vy-iosupdate to be available (will need to upgrade to2.2.1) gr4vy/gr4vy-ios#12Ticket: https://gr4vy.atlassian.net/browse/TA-7501