Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build both x86_64 and arm64 macOS DMG's #1388

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yuzawa-san
Copy link
Contributor

fixes #1104

  • i tried doing the conda version, but found that the qt in there does not bundle properly and was bundling the libraries twice. i may dig into it further later, but this still uses the brew installation methodology
  • there are a few gotchas:
  • the macos-13 GH runner is x86_64 only in the free tier and the macos-14 GH runner is arm64 only in the free tier, so technically the two produced artifacts have different OS baselines. both brew and conda do not produce universal2 binaries and seem to pin to the OS baselines, so not much i think we could do to get out of this. when we move to macos-14 baseline in the future (since one day macos-13 will be deprecated like macos-12 just was), we will only have an arm64 CI/build environment. this would normally bother me, but given apple has not made an intel laptop since 2019 and they are a few years away from dropping support on macos-13, it should probably work for most people.
  • soapyremote is in the main brew repository now. pothos has SoapyPlutoSDR but the dependencies libad9361 and libiio are not up to date. ideally we could eventually move back to the pothos version.
  • homebrew moved the prefix (on arm64) from /usr/local to /opt/homebrew which was annoying to support.
  • macos-13 still has weirdness with the permissions on /usr/local so more sudo is needed.
  • build Release versions using cmake
  • remove CFBundleGetInfoString since its deprecated and the "get info" in the Finder uses the version string now
  • upgrade CI to use "macos-latest" which is currently macos-14 but will eventually be macos-15.
  • i found the quirks in the bundle script around broti, png, sharpuv, freetype were not needed since the libraries appeared to be properly relocated. i could not find any history around why those carveouts existed.
  • if i had to guess i broke something in this, it would be around soapyplutosdr or something soapy
  • my test build https://github.com/yuzawa-san/gqrx/actions/runs/11431458195
  • i QA'd on my own x86_64 sonoma mac and found it worked. i had a friend try to QA on their arm64 sequoia mac but the system integrity mode choked on the unsigned artifact. so i'll open this PR and they the signed one built here. once i validate that with my friend's computer i'll take this out of draft mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple Silicon / M1 builds?
1 participant