-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/uv #81
Conversation
@@ -0,0 +1,1024 @@ | |||
version = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think we need to check this file in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure on this one to be fair, as heroku doesn't support uv by default, we need a preprocessor to generate requirements.txt from uv.lock here
I remember from when I used poetry, having .lock in VCS was the correct practice when producing an executable, not a library.
@@ -1 +0,0 @@ | |||
python-3.13.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC this was needed for heroku not for the package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the previous reply, this gets generated via the buildpack on heroku side.
SHould also update the procfile cause that's what heroku will run |
heroku/heroku-buildpack-python#1616 states that uv has no full support for uv, so basically what this does is just uses uv for the development, heroku would still use the default python worker. We can also stick with the current way in favor of having easier deploy and not having uv for personal development @msaroufim . Another thing to be possibly done, is to create a custom heroku dependencies which install uv for us, but not really in favour of that. |
Yeah unfortunately without heroku having better support for uv I feel like this PR adds more complexity for some benefit and I don't feel like it's super worth it yet |
Absolutely, in that case I'm closing it for now. Will stay with pip as is |
Description
Moves the whole project to use
uv
instead of vanilla pip, it makes development process easier with a price of small changes to heroku deploy (adding a preprocessing buildpack as heroku doesn't natively support uv yet)Also moves the whole configuration to
pyproject.toml
, enabling development dependencies and also configuring ruff in one place.All updates are reflected in the readme.
Checklist
Before submitting this PR, ensure the following steps have been completed:
/verifyruns
on your own server./verifyruns
.runs may take a little longer. The Modal run is typically quick.)
For more information on running a cluster bot on your own server, see
README.md.