-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fewer Oscillators = More Fun #10
Open
nickbailey
wants to merge
27
commits into
gperciva:master
Choose a base branch
from
nickbailey:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wouldn't say that I'm not interested -- I'm certainly more interested in "teaching" than the "publication" side of academia! But the second part of Feb is really busy for me. I'll take a look at detangling the branch conflicts in March, unless you tackle it sooner. :) |
On Tuesday, 21 February 2017 09:14:26 GMT Graham Percival wrote:
I wouldn't say that I'm not interested -- I'm certainly more interested in
"teaching" than the "publication" side of academia! But the second part of
Feb is really busy for me. I'll take a look at detangling the branch
conflicts in March, unless you tackle it sooner. :)
They are nothing much. You changed some variables from class to object ones
(i.e. self.x -- not sure the exact Python terminology). I've also done a new
page with a simple PyQt GUI and a MIDI receiver so they can make their
oscillators play. I'll put it all on the Git repo when I've written the lab
up. If you're busy (glad to hear that!) you might want to ignore everything
until the next pull request.
I'll be deleting the lookup table and filter-by-polynomial stuff soon because
it's now covered elsewhere. About time really.
The downside is that possible the only true example of lookup-table length
calculation on the internet will disappear! Everyone else seems to be
parrotting the lies I was taught. Until you actually tested it of course.
Still, good riddance. I'll leave it to the VHDL guys.
In other news, it turns out that the CS department is also having trouble with
new undergrads who can't formulate algorithms ─ even trivial ones. The
difference is, they have developed a new course to teach it! I'm trying to go
and see the chap who gives it in the next few days.
N/.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess you're not too interested in this any more.
Fact is, Bernd (before he got so successful at film making he went part time) put a lot of DSP and programming in place which means I can delete a lot of the filters stuff. Also, the VLSI guys got some new kit and are doing VLSI properly so I can delete the lookup table stuff finally.
This is an interim state so there's things need fixing (exercise numbers etc). Also, there's going to be a GUI programming thing soon with Qt widgets and audio callbacks. So they will be calling methods written in C++ via swig to respond to MIDI events and controlling things like resonator Q with sliders. A bit more like audio programming? Better late than never.
N/.
PS: I didn't merge your changes first. Sorry about that. Bit rushed. Funeral tomorrow; lab Wednesday.