Check that auxiliary tracks have 'auxv' as the handler_type #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbouqueau
reviewed
Sep 21, 2022
According to the HEIF specification, auxiliary tracks should have 'auxv' as the handler_type. Update the existing findAuxlTracks logic to check for that and then perform the 'auxi' check only on those tracks which have the handler_type as 'auxi'. Fixes issue gpac#38.
leo-barnes
approved these changes
Sep 22, 2022
| @@ -66,22 +66,32 @@ displayable (not hidden) | |||
|
|
|||
| Specification description: HEIF - ISO/IEC 23008-12 - 2nd Edition N18310 | |||
|
|
|||
| [heif][Rule #1] Error: Found 'auxl' track (trackId: 1) with unexpected handler_type="pico". Must be 'auxv'. | |||
There was a problem hiding this comment.
Suggested change
| [heif][Rule #1] Error: Found 'auxl' track (trackId: 1) with unexpected handler_type="pico". Must be 'auxv'. | |
| [heif][Rule #1] Error: Found 'auxl' track (trackId: 1) with unexpected handler_type="pict". Must be 'auxv'. |
There was a problem hiding this comment.
Or wait, maybe this was intended...
| @@ -503,7 +503,7 @@ moov_start: | |||
| db 0x00 ; "version(8)" | |||
| db 0x00, 0x00, 0x00 ; "flags(24)" | |||
| db 0x00, 0x00, 0x00, 0x00 ; "pre_defined(32)" | |||
| db 0x70, 0x69, 0x63, 0x74 ; "handler_type(32)" ('pict') | |||
| db 0x61, 0x75, 0x78, 0x76 ; "handler_type(32)" ('pict') | |||
There was a problem hiding this comment.
Suggested change
| db 0x61, 0x75, 0x78, 0x76 ; "handler_type(32)" ('pict') | |
| db 0x61, 0x75, 0x78, 0x76 ; "handler_type(32)" ('auxv') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the HEIF specification, auxiliary tracks should have 'auxv' as the handler_type.
Update the existing findAuxlTracks logic to check for that and then perform the 'auxi' check only on those tracks which have the handler_type as 'auxi'.
Fixes issue #38.