Remove all the code associated with type checking #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbarth
force-pushed
the
revert-type-tools
branch
from
cfead2e
to
bf88855
Compare
|
I've rebased this PR and make sure all the tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've moved all this type checking code to another repo so that we don't muddy the purpose of
xpathwith them. See https://github.com/xmldom/is-dom-nodeCurrently the type checking/asserting code either needs to be fixed or ripped out because of problem with it. I'm sorry for the run-around on this @JLRishe . I see you've been very busy and hardly active on GitHub at all lately, so I'd like to make this as easy as possible on you and allow you to focus on the much more stable base mission of
xpathand not have to deal with the comparatively more chaotic world of TypeScript.Ideally, my other PR about adding tests (#131) would land first and then I can tweak this to really remove all the code added over the past 2 months or so.
Closes: #121, #123, #127