fix: add Get latest job runs API #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbchaos
approved these changes
Sep 25, 2024
| @@ -40,6 +40,12 @@ service JobRunService { | |||
| get: "/v1beta1/project/{project_name}/job/{job_name}/run" | |||
| }; | |||
| } | |||
| // JobRunList returns the current and past run status of jobs on a given range | |||
| rpc GetLatestJobRuns(GetLatestJobRunsRequest) returns (GetLatestJobRunsResponse) { | |||
There was a problem hiding this comment.
I'm thinking of keeping the number of rpc methods to less by merging the scope of this rpc method with the existing rpc method to get jobruns, should we look into where all we are using the existing method & try to unify them instead.
|
We shall add a new api GetLatestJobRuns which shall have filters
In absence of the filters the API will respond with status info of a single latest run(by schedule). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.