Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update approval check for self approval #178

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

utsav14nov
Copy link

Proton Pr: goto/proton#123

@utsav14nov utsav14nov linked an issue Aug 27, 2024 that may be closed by this pull request
@anjaliagg9791
Copy link

logic looks good to me.

Copy link
Collaborator

@Gadigeppa-J Gadigeppa-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

domain/policy.go Outdated Show resolved Hide resolved
domain/policy.go Show resolved Hide resolved
domain/policy.go Show resolved Hide resolved
@Gadigeppa-J Gadigeppa-J merged commit b87bd5a into main Aug 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding check to not allow self approval.
4 participants