fix: review comment by muthu

goto · Oct 8, 2024 · d7e9e71 · d7e9e71
1 parent 454ae50
commit d7e9e71
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/plugins/providers/shield/config.go b/plugins/providers/shield/config.go
@@ -18,10 +18,10 @@ const (
 )
 
 type Credentials struct {
-	Host       string `json:"host" mapstructure:"host" validate:"required"`
-	AuthHeader string `json:"auth_header" mapstructure:"auth_header" validate:"required"`
-	AuthEmail  string `json:"auth_email" mapstructure:"auth_email" validate:"required"`
-	Version    string `json:"version" mapstructure:"version"`
+	Host          string `json:"host" mapstructure:"host" validate:"required"`
+	AuthHeader    string `json:"auth_header" mapstructure:"auth_header" validate:"required"`
+	AuthEmail     string `json:"auth_email" mapstructure:"auth_email" validate:"required"`
+	ClientVersion string `json:"client_version" mapstructure:"client_version"`
 }
 
 type Permission string

diff --git a/plugins/providers/shield/provider.go b/plugins/providers/shield/provider.go
@@ -130,7 +130,7 @@ func (p *provider) GetClient(providerURN string, credentials Credentials) (Shiel
 		return p.Clients[providerURN], nil
 	}
 
-	if credentials.Version == "new" {
+	if credentials.ClientVersion == "new" {
 		client, err := NewShieldNewClient(&ClientConfig{
 			Host:       credentials.Host,
 			AuthHeader: credentials.AuthHeader,

diff --git a/plugins/providers/shield/provider_test.go b/plugins/providers/shield/provider_test.go
@@ -1457,10 +1457,10 @@ func TestGetClient(t *testing.T) {
 		p := shield.NewProvider("", logger)
 
 		creds := shield.Credentials{
-			Host:       "http://localhost.com",
-			AuthEmail:  "test-email",
-			Version:    "new",
-			AuthHeader: "test-header",
+			Host:          "http://localhost.com",
+			AuthEmail:     "test-email",
+			ClientVersion: "new",
+			AuthHeader:    "test-header",
 		}
 
 		_, err := p.GetClient(providerURN, creds)