Skip to content
This repository has been archived by the owner on Sep 27, 2022. It is now read-only.

Update Rails to 5.1.0, convert to API-only application, style refactorings #10

Merged
merged 1 commit into from
May 8, 2017

Conversation

ahcarpenter
Copy link

@ahcarpenter ahcarpenter commented May 3, 2017

  • Update to Rails 5.1
  • handle CORS
  • add Rubocop, refactor style to more closely align with community style guide
  • convert to API-only app

Resolves #5, #7, #8, #9

@ahcarpenter ahcarpenter changed the title Convert to Rails 5.1, handle CORS requests, add Rubocop, ... Update Rails to 5.1.0, convert to API-only application, style refactorings May 3, 2017
@ahcarpenter
Copy link
Author

@apai4 any thoughts?

@apai4
Copy link
Member

apai4 commented May 8, 2017

@ahcarpenter Thanks a bunch for doing this, this looks great!

I'd like to wait until acts-as-taggable-on and devise release official gems for Rails 5.1 instead of relying on GitHub for those dependencies. I'll pull this into a new branch where we can continue to accept changes for 5.1. Once the new gem versions are released we can update master to 5.1

@apai4 apai4 changed the base branch from master to rails-5.1 May 8, 2017 18:07
@apai4 apai4 merged commit 66079af into gothinkster:rails-5.1 May 8, 2017
@ahcarpenter
Copy link
Author

@apai4 sure thing!

sounds good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants