-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synced go.mod with original vendors.json, additional minor clean-up. #24
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind. Seems in latest github we have to move hooks to the github actions.
I will fix later..
Please run the |
I ran the coverage script as instructed but it is not working -- it
produces an empty coverage.txt and outputs the following to the terminal:
? github.com/gothinkster/golang-gin-realworld-example-app/articles
[no test files]
However, when I run "go test ./... -coverprofile cover.out", sometimes it
outputs the following to the terminal:
? github.com/gothinkster/golang-gin-realworld-example-app [no test
files]
? github.com/gothinkster/golang-gin-realworld-example-app/articles
[no test files]
ok github.com/gothinkster/golang-gin-realworld-example-app/common
0.007s coverage: 100.0% of statements
< lots of errors, starting with a SQLite disk I/O error>
and sometimes it outputs:
? github.com/gothinkster/golang-gin-realworld-example-app [no test
files]
? github.com/gothinkster/golang-gin-realworld-example-app/articles
[no test files]
ok github.com/gothinkster/golang-gin-realworld-example-app/common
0.007s coverage: 100.0% of statements
ok github.com/gothinkster/golang-gin-realworld-example-app/users
4.061s coverage: 100.0% of statements
The odd thing is that "go test ./..." always outputs:
? github.com/gothinkster/golang-gin-realworld-example-app [no test files]
? github.com/gothinkster/golang-gin-realworld-example-app/articles [no
test files]
ok github.com/gothinkster/golang-gin-realworld-example-app/common 0.010s
ok github.com/gothinkster/golang-gin-realworld-example-app/users (cached)
So the tests are running fine but there may be some memory or tmp space
limitation that is affecting SQLite when the tests are run with coverage.
…On Wed, Mar 31, 2021 at 7:09 AM wangzitian0 ***@***.***> wrote:
Please run the script: part inside
https://github.com/gothinkster/golang-gin-realworld-example-app/blob/master/.travis.yml
on local enviroment. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD4LPORQT55ZLYVD55AUBTTGL7GXANCNFSM42EKDNEQ>
.
|
@pvillela Could you please update the readme as the repo have use the go mod? As long as the basic script works fine, it was okay to me whether we use latest packages. |
Done. See new PR.
…On Sun, Apr 11, 2021 at 5:15 AM wangzitian0 ***@***.***> wrote:
@pvillela <https://github.com/pvillela> Could you please update the
readme as the repo have use the go mod? As long as the basic script works
fine, it was okay to me whether we use latest packages.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD4LPL3JFANKIHXZ3HAS7DTIFSBLANCNFSM42EKDNEQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I suspect the problems you reported are due to changes in some of the dependencies. I went back to your previous commit on master, regenerated go.mod, and synced it with vendor.json (go mod vendor). After that, I again removed the dependence on the starter-kit repo. Again, all unit tests passed.