Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synced go.mod with original vendors.json, additional minor clean-up. #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pvillela
Copy link
Contributor

I suspect the problems you reported are due to changes in some of the dependencies.  I went back to your previous commit on master, regenerated go.mod, and synced it with vendor.json (go mod vendor).  After that, I again removed the dependence on the starter-kit repo.  Again, all unit tests passed.

Copy link
Collaborator

@wangzitian0 wangzitian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. Seems in latest github we have to move hooks to the github actions.
I will fix later..

@wangzitian0
Copy link
Collaborator

Please run the script: part inside https://github.com/gothinkster/golang-gin-realworld-example-app/blob/master/.travis.yml on local enviroment. Thanks!

@pvillela
Copy link
Contributor Author

pvillela commented Mar 31, 2021 via email

@wangzitian0
Copy link
Collaborator

@pvillela Could you please update the readme as the repo have use the go mod? As long as the basic script works fine, it was okay to me whether we use latest packages.

@pvillela
Copy link
Contributor Author

pvillela commented Apr 11, 2021 via email

Copy link
Collaborator

@wangzitian0 wangzitian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants