Skip to content

Commit

Permalink
For new signin link, use target=_top so iframes work
Browse files Browse the repository at this point in the history
Currently, no target set in the iframe can rain on some parades. This makes sure no rain happens, only _Slackshine_.

Couldn't resist..
  • Loading branch information
sc0ttkclark committed Sep 8, 2015
1 parent 27cc41b commit 24950d2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/splash.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default function splash({ name, org, logo, active, total, channels, ifram
),
!iframe && dom('p.signin',
'or ',
dom(`a href=https://${org}.slack.com`, 'sign in'),
dom(`a href=https://${org}.slack.com target=_top`, 'sign in'),
'.'
),
!iframe && dom('footer',
Expand Down

0 comments on commit 24950d2

Please sign in to comment.