Fix problems reported by PHPStan #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
commented
Dec 26, 2022
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| namespace Gosuperscript\ZeroDowntimeEventReplays\Exceptions; | |||
|
|
|||
| class CreateReplayException extends \Exception | |||
| final class CreateReplayException extends \Exception | |||
There was a problem hiding this comment.
Protect static in line number 9.
szepeviktor
commented
Dec 26, 2022
| })->each(function ($defaultValue) use ($model, $ghostConnectionTable, &$statements) { | ||
| })->each(function ($defaultValue) use ($ghostConnectionTable, &$statements) { |
szepeviktor
commented
Dec 26, 2022
| @@ -62,17 +62,17 @@ public function removeConnection(): void | |||
| return $model->getConnectionName(); | |||
| })->each(function ($models, $connection) { | |||
| $tables = []; | |||
| $statements = []; | |||
There was a problem hiding this comment.
Is it en error or $statements array should be emptied in each iteration?
szepeviktor
commented
Dec 26, 2022
| return parent::register(); // TODO: Change the autogenerated stub | ||
| parent::register(); // TODO: Change the autogenerated stub |
There was a problem hiding this comment.
register() should not return anything.
There is an error in ./vendor/spatie/laravel-package-tools/src/PackageServiceProvider.php too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see comments 👇🏻