refactor: redefine Key from an alias of ebiten.Key to a general int type
#484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int` type Since goplus/gogen doesn't yet support `go/types.Alias` (a Go 1.22 feature), spxls in Go+ Builder fails when doing multi-key bindings (see goplus/builder#1199 (comment)). This represents the simplest approach to fix the issue mentiond. Signed-off-by: Aofei Sheng <[email protected]>
|
Closing in favor of goplus/gogen#459. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since goplus/gogen doesn't yet support
go/types.Alias(a Go 1.22 feature), spxls in Go+ Builder fails when doing multi-key bindings (see goplus/builder#1199 (comment)).This represents the simplest approach to fix the issue mentiond.