redesign: runner header #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nighca
reviewed
Apr 30, 2024
| .close { | ||
| position: absolute; | ||
| right: 20px; | ||
| transform: scale(1.2); |
There was a problem hiding this comment.
这么实现的话这个 close 跟两侧的距离都会不准确吧
另外我感觉这个 close btn 的特殊大小应该不是只针对 RunnerContainner 的，而可能是针对 FullScreenModal 的，是的话可以考虑做到 @/components/ui/modal 里；虽然按你现在的抽象方式，不好直接做到 FullScreenModal 里，不过可以把对这个特定 size 的支持先做到 UIModalClose 里
nighca
approved these changes
Apr 30, 2024
|
The PR environment is ready, please check the PR environment [Attention]: This environment will be automatically cleaned up after a certain period of time., please make sure to test it in time. If you have any questions, please contact the builder team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.