Re-organize implementation for various block items #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Copilot reviewed 35 out of 50 changed files in this pull request and generated no comments.
Files not reviewed (15)
- spx-gui/src/components/asset/animation/CostumeItem.vue: Evaluated as low risk
- spx-gui/src/components/asset/animation/GroupCostumesModal.vue: Evaluated as low risk
- spx-gui/src/components/asset/library/BackdropItem.vue: Evaluated as low risk
- spx-gui/src/components/asset/library/SoundItem.vue: Evaluated as low risk
- spx-gui/src/components/asset/library/SpriteItem.vue: Evaluated as low risk
- spx-gui/src/components/asset/preprocessing/CostumeItem.vue: Evaluated as low risk
- spx-gui/src/components/asset/preprocessing/PreprocessModal.vue: Evaluated as low risk
- spx-gui/src/components/asset/scratch/BackdropItem.vue: Evaluated as low risk
- spx-gui/src/components/asset/scratch/SoundItem.vue: Evaluated as low risk
- spx-gui/src/components/asset/scratch/SpriteItem.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/resource-reference/selector/ResourceSelector.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/resource/AnimationItem.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/resource/BackdropItem.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/resource/CostumeItem.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/resource/ResourceItem.vue: Evaluated as low risk
nighca
force-pushed
the
issue-1138-pre
branch
from
8b4f51a to
2346276
Compare
nighca
force-pushed
the
issue-1138-pre
branch
from
2346276 to
d48c7d2
Compare
|
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
aofei
approved these changes
Feb 5, 2025
Merged
nighca
commented
Feb 11, 2025
| @@ -99,6 +99,7 @@ defineExpose({ | |||
| } | |||
|
|
|||
| .icon { | |||
| flex: 0 0 auto; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Sprite|Backdrop|Animation|Costume|Sound|Widget)Itemsto eliminate redundant implementations for the same resource type in preparation for Animation preview in sprite / animation block #1280.ResourceSelectorof the code editor.WidgetsEditor.