Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tools/spxls): centralize source location handling in compileResult #1273

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

aofei
Copy link
Member

@aofei aofei commented Jan 24, 2025

No description provided.

Copy link

qiniu-prow bot commented Jan 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@aofei aofei requested a review from Copilot January 26, 2025 00:46
@aofei aofei marked this pull request as ready for review January 26, 2025 00:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • tools/spxls/internal/server/compile.go: Evaluated as low risk
  • tools/spxls/internal/server/document.go: Evaluated as low risk
  • tools/spxls/internal/server/server.go: Evaluated as low risk
  • tools/spxls/internal/server/highlight.go: Evaluated as low risk
  • tools/spxls/internal/server/reference.go: Evaluated as low risk
Comments suppressed due to low confidence (1)

tools/spxls/internal/server/rename.go:35

  • [nitpick] The function util.ToPtr is used here, but it is not clear what it does from the context. Consider inlining the logic for clarity if it is specific to this use case.
return util.ToPtr(result.rangeForNode(ident)), nil
@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@nighca nighca merged commit c0ed9c5 into goplus:dev Jan 26, 2025
8 checks passed
@aofei aofei deleted the spxls branch January 26, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants