Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address TODO items for code-editor #1260

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Address TODO items for code-editor #1260

merged 2 commits into from
Jan 23, 2025

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Jan 22, 2025

Copy link

qiniu-prow bot commented Jan 22, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@nighca nighca changed the title Review remaining "TODO"s in code-editor related code Address TODO items in code-editor related code Jan 22, 2025
@nighca nighca changed the title Address TODO items in code-editor related code Address TODO items for code-editor Jan 22, 2025
@nighca nighca requested a review from Copilot January 23, 2025 01:00

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 25 out of 40 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • spx-gui/src/components/editor/code-editor/ui/copilot/CopilotTrigger.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/completion/CompletionItem.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/command/CommandIcon.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/copilot/UserMessage.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/copilot/CopilotUI.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/copilot/CopilotInput.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/CodeEditorUI.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/api-reference/APIReferenceItem.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/api-reference/APIReferenceUI.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/common.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/text-document.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/completion/index.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/code-editor.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/common.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/copilot/index.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)

spx-gui/src/components/editor/code-editor/ui/code-editor-ui.ts:263

  • Ensure that the editor.focus() method call after inserting text is covered by tests.
this.editor.focus()

spx-gui/src/components/editor/code-editor/ui/code-editor-ui.ts:282

  • Ensure that the editor.focus() method call after inserting a snippet is covered by tests.
this.editor.focus()
@nighca nighca marked this pull request as ready for review January 23, 2025 03:10
@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@aofei aofei merged commit bdebe1e into goplus:dev Jan 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review remaining "TODO"s in code-editor related code
3 participants