Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling UpdateVersionedAssetsOnUpdate with each Play in Editor. #587

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bhallionOhbibi
Copy link

@bhallionOhbibi bhallionOhbibi commented Dec 28, 2022

Avoid unecessary computation of manifest each time the play mode is started in editor.
This computation takes multiple seconds each time we press play on many projects.
This computation is already made with each asset refresh.

Please note that this was already made on the firebase-unity-sdk equivalent few years ago: GenerateXmlFromGoogleServicesJson
https://github.com/firebase/firebase-unity-sdk/blob/778a4841ac67616b2bd88a6e6f740a816d75b13b/editor/app/src/GenerateXmlFromGoogleServicesJson.cs#L96

@Tommigun1980
Copy link

Please please please accept this pull request. It is completely unacceptable that the resolver makes iterating projects slower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants