Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all versions of Martinique flag #446

Closed
wants to merge 1 commit into from

Conversation

chrism
Copy link

@chrism chrism commented Nov 24, 2023

The current version of the Martinique Flag is outdated

MQ

This PR updates it to the correct version for all formats (html/png/svg/waved-svg)

MQ

@anthrotype
Copy link
Member

Thanks. Can you please confirm where the assets come from or how they were generated?
Did you use https://github.com/fonttools/region-flags to download the flag from wikipedia and convert to optimized PNG?
And did you use https://github.com/rsheeter/warp to make the "waved" svg version?

I noticed that https://github.com/googlefonts/noto-emoji/tree/main/third_party/region-flags contains a REDME that mentions a bunch of scripts which aren't there any more, maybe we should update the instructions. /cc @rsheeter @behdad

@chrism
Copy link
Author

chrism commented Nov 24, 2023

Hi @anthrotype, sure thing.

Did you use https://github.com/fonttools/region-flags to download the flag from wikipedia and convert to optimized PNG?

Yes

And did you use https://github.com/rsheeter/warp to make the "waved" svg version?

Yes

I noticed that https://github.com/googlefonts/noto-emoji/tree/main/third_party/region-flags contains a REDME that mentions a bunch of scripts which aren't there any more, maybe we should update the instructions. /cc @rsheeter @behdad

tbh there were a few confusing aspects to the process.

Like you say, the scripts referred to in the googlefonts README do not exist, but I found them via this issue
#164

The process to generate the waved svg is not included in the https://github.com/fonttools/region-flags repo but I found it via this issue
#3

@rsheeter
Copy link
Contributor

Thank you for the PR. I looked into this and our flags policy has evolved to require the asset come from the relevant government (admittedly contrary to the current documentation of region flags) so I do not believe I can merge this. I will update the font to include an updated flag.

@rsheeter rsheeter closed this Nov 29, 2023
@rsheeter
Copy link
Contributor

I should add that I really appreciate the effort and apologize for not being able to accept the PR

@rsheeter
Copy link
Contributor

Update in #448

@chrism
Copy link
Author

chrism commented Dec 4, 2023

Hi @rsheeter no problem, just happy to see the flag has been changed. Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants