remove spurious continue in _bracket_info() #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this if branch was never true probably because of a typo (the author probably meant to compare axis.minimum with 'axis_min' instead of 'axis_max'), besides it would be incorrect to ignore such an always-true axis rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this
ifbranch was never true because of a typo (the author probably meant to compare axis.minimum with 'axis_min' instead of 'axis_max'); but besides that, even if we did fix the typo, it would be incorrect to ignore such an explict always-true axis rule where both min and max are explicitly declared and are equal to the axis min/max. Glyphs.app exports a GSUB with a FeatureVariation table with an empty condition set (which means always apply), and fontmake does the same.The PR doesn't change anything, only removes code that's never evaluated so no functional change.