Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip disabled custom parameters when glyphs=>ufo and minimal=True #1036

Merged
merged 2 commits into from
Oct 3, 2024
Merged

skip disabled custom parameters when glyphs=>ufo and minimal=True #1036

merged 2 commits into from
Oct 3, 2024

Conversation

anthrotype
Copy link
Member

@anthrotype anthrotype commented Oct 3, 2024 •
edited
Loading

toward fixing #905

@anthrotype
Copy link
Member Author

anthrotype commented Oct 3, 2024 •
edited
Loading

(I can add some tests after lunch)

Added a test as well

@anthrotype anthrotype mentioned this pull request Oct 3, 2024
Closed
@anthrotype anthrotype merged commit 9d5828d into main Oct 3, 2024
10 checks passed
@anthrotype anthrotype deleted the skip-disabled-params branch October 3, 2024 13:31
@anthrotype anthrotype mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaledhosny khaledhosny khaledhosny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthrotype @khaledhosny