markFeatureWriter: Use new ufo2ft MarkFeatureWriter #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be merged after the new ufo2ft release and requiring it as minimum supported version. |
khaledhosny
force-pushed
the
move-contextual-mark-feature-writer-to-ufo2ft
branch
from
6a0cf3d
to
171dd6d
Compare
khaledhosny
force-pushed
the
move-contextual-mark-feature-writer-to-ufo2ft
branch
from
171dd6d
to
b1d41e9
Compare
khaledhosny
force-pushed
the
move-contextual-mark-feature-writer-to-ufo2ft
branch
3 times, most recently
from
4325c2d
to
6adf304
Compare
The code here was merged back to ufo2ft’s MarkFeatureWriter. Keeping ContextualMarkFeatureWriter as stub just in case someone is using it directly. Keeping the tests too, to exercise exporting anchor libData to UFO.
khaledhosny
force-pushed
the
move-contextual-mark-feature-writer-to-ufo2ft
branch
from
6adf304
to
d436f8f
Compare
khaledhosny
deleted the
move-contextual-mark-feature-writer-to-ufo2ft
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code here was merged back to ufo2ft’s MarkFeatureWriter. Keeping ContextualMarkFeatureWriter as stub just in case someone is using it directly. Keeping the tests too, to exercise exporting anchor libData to UFO.