Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Wrong escape sequences #1007

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Wrong escape sequences #1007

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd5d626
fix: Wrong escape sequences
aragon999 Jul 15, 2024
7e3d72f
fix: Make sure that the filepath shell arguments are enclosed in quotes
aragon999 Jul 16, 2024
4715633
style: Codestyle linting
aragon999 Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/gftools/builder/operations/autohintOTF.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@

class AutohintOTF(OperationBase):
description = "Run otfautohint"
rule = "otfautohint $args -o $out $in \|\| otfautohint $args -o $out $in --no-zones-stems"
rule = "otfautohint $args -o $out $in \\|\\| otfautohint $args -o $out $in --no-zones-stems"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arrowtype's traceback shows,

otfautohint: error: argument -o/--output: /fonts/Familyname/|| is not a valid path to write to.

The or operator looks well escaped. The issue is that the or operator is attached to the filename. Perhaps quoting the $out and $in args will work e.g

'otfautohint $args -o "$out" "$in" \|\| otfautohint $args -o "$out" "$in" --no-zones-stems'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, probably the $in and $out arguments should be escaped with quotes. I will adjust that. The thing I encountered was actually a Python warning:
image

2 changes: 1 addition & 1 deletion Lib/gftools/push/items.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def parse_html(string: str):
if not string:
return None
text = BeautifulSoup(string, features="lxml").text
return re.sub("\s+", " ", text).strip()
return re.sub(r"\s+", " ", text).strip()


@dataclass
Expand Down