Merge pull request #713 from googlefonts/fix-empty-sample-text

Stop duplicating empty sample text
googlefonts · Sep 6, 2023 · 567a71e · 567a71e
2 parents c0f2c7e + 53e35a2
commit 567a71e
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/Lib/gftools/scripts/add_font.py b/Lib/gftools/scripts/add_font.py
@@ -150,7 +150,7 @@ def _MakeMetadata(args, is_new):
       metadata.display_name = old_metadata.display_name
     if old_metadata.primary_script:
       metadata.primary_script = old_metadata.primary_script
-    if old_metadata.sample_text:
+    if old_metadata.sample_text and old_metadata.sample_text.ByteSize():
       metadata.sample_text.CopyFrom(old_metadata.sample_text)
     if old_metadata.minisite_url:
       metadata.minisite_url = old_metadata.minisite_url