Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare supported export formats in backend #1879

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Declare supported export formats in backend #1879

wants to merge 4 commits into from

Conversation

simoncozens
Copy link
Contributor

Fixes #1878. FontraPak PR incoming.

Also makes "find-glyphs-that-use-glyph" conditional on the server supporting it.

@simoncozens simoncozens mentioned this pull request Dec 20, 2024
Open
@justvanrossum
Copy link
Collaborator

I'm not sure I like the addition of the supportedExportFormats field to the protocol while exportAs() is entirely optional. Perhaps it's better to have an additional optional partner method called getSupportedExportFormats().

Ideally the changes should not affect https://github.com/googlefonts/fontra-rcjk/blob/main/src/fontra_rcjk/projectmanager.py

@simoncozens
Copy link
Contributor Author

Fair enough, yes. Will rethink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project manager should declare export formats
2 participants
@simoncozens @justvanrossum