Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use glyphsLib minimal builds #810

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Use glyphsLib minimal builds #810

merged 2 commits into from
Sep 28, 2021

Conversation

khaledhosny
Copy link
Collaborator

This tells glyphsLib to create enough UFO for building binary fonts and discard any unneeded data.

This requires glyphsLib 6.0.0 or later.

@khaledhosny
Copy link
Collaborator Author

Looks like pypy3 does not like the new glyphsLib parser.

@anthrotype
Copy link
Member

uh-oh yes.. fonttools/openstep-plist#12

@anthrotype
Copy link
Member

anthrotype commented Sep 27, 2021

I had not realised that with glyphsLib 6 and the concomitant switch to openstep-plist parser, we would lose pypy support. That's a pity, but for the time being there's no quick fix and we may have to temporarily drop support for pypy until we figure out how to make it happy. I suggest we open an issue here and/or on glyphsLib to track this, linking to fonttools/openstep-plist#12, and here we temporarily comment out the pypy3 tests in the CI config file (with a TODO and a link to the issue)

This tells glyphsLib to create enough UFO for building binary fonts and
discard any unneeded data.

This requires glyphsLib 6.0.0 or later.
@khaledhosny
Copy link
Collaborator Author

we temporarily comment out the pypy3 tests in the CI config file (with a TODO and a link to the issue)

Done

@khaledhosny khaledhosny merged commit b38e8ee into googlefonts:main Sep 28, 2021
@khaledhosny khaledhosny deleted the glyphslib-minimal branch September 28, 2021 14:32
@anthrotype
Copy link
Member

I think we can tag a major version bump v3.0.0b1 instead of v2.5.0b1 -- given we dropped support for python 3.6 and pypy3, we add support for Glyphs 3, we will soon. add support for iondrive (#802)

@khaledhosny
Copy link
Collaborator Author

Sounds good.

@anthrotype
Copy link
Member

@khaledhosny https://pypi.org/project/fontmake/3.0.0b1/

@khaledhosny
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants