[fontbe] Fix incorrect feature deltas w/ sparse glyph sources #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
approved these changes
Apr 18, 2024
| ) | ||
| .unwrap(); | ||
| &local_model | ||
| }; |
There was a problem hiding this comment.
agree it's annoying that we have two versions of this impl, let's open an issue to try and fix this.
There was a problem hiding this comment.
yeah. If we do consolidate these two implementations of resolve_variable_metric, maybe we could use a struct and let the method take &mut self so we can store a cache of prebuilt variation models to reuse when we see the same set of locations, instead of making new ones each time
anthrotype
force-pushed
the
fix-incorrect-feature-deltas-when-sparse
branch
from
2c0e2f5
to
1fb958d
Compare
anthrotype
force-pushed
the
fix-incorrect-feature-deltas-when-sparse
branch
from
1fb958d
to
326a91c
Compare
…ocations only excluding the locations for intermediate or sparse layers which only contribute glyph sources, not metrics nor kerning
….locations() or else reuse the global StaticMetadata.variation_model, which will now only includes 'full' masters (i.e. defining kerning) for both UFOs+DS and .glyphs input. This fixes 'incorrect feature deltas when sparse' #407
anthrotype
force-pushed
the
fix-incorrect-feature-deltas-when-sparse
branch
from
326a91c
to
a55c7b2
Compare
will be fixed by #779
|
the same test that failed in #817 passed with this PR branch |
|
given that Colin already LGTM'ed this PR before I had added the test, I'll just go on and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 'incorrect feature deltas when sparse' #407
The global StaticMetadata.variation_model now only includes 'full' masters (i.e. defining kerning) for both UFOs+DS and .glyphs input (previously this was the case only for the latter).
When we call
resolve_variable_metricwe make new sub-model when locations != global_model.locations(), or just reuse the global model when locations are equal -- which is currently basically always true for the common source formats (DS and glyphs) in the case of kerning, as the latter is meant to be "dense" and can only be specified for the "full" or globally-defined masters. However, we don't preclude the possibility that in the future other (or newer) source formats may define sparse kerning data, and our fontbe is ready for that.I added a test file in #776, and verified locally that this patch fixes the issue #407, but
I haven't find the time to make an actual unit test yet. If I don't make it in time, you should be able connect the dots...EDIT: I have added a test case #817