Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fea-rs] ensure first wins when specific kern rules conflict #566

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

anthrotype
Copy link
Member

Thanks @simoncozens for reporting this and proposing a fix, I just applied that and added a test for confirm.

https://adobe-type-tools.github.io/afdko/OpenTypeFeatureFileSpecification.html#6bii-enumerating-pairs

Specific pairs generated by an enum rule may be overridden by specifying preceding single pairs. Because of this case, it is not an error when specific kern pairs conflict because they have the same glyphs. When specific kern pair rules conflict, the first rule specified is used, and later conflicting rule are skipped.

Fixes #550

@anthrotype anthrotype added this pull request to the merge queue Nov 11, 2023
Merged via the queue into main with commit a784900 Nov 11, 2023
9 checks passed
@anthrotype anthrotype deleted the early-kern-pair-wins branch November 11, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fea-rs] Early kern rules should override later ones, not the other way around
2 participants