Don't block on glyph order if you don't have to #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
force-pushed
the
threads
branch
2 times, most recently
from
c4f45ff to
314ebb3
Compare
rsheeter
changed the title
|
I'm seeing be work (blue) launch earlier (not wait until the right edge of glyph order) as expected. However, that work is managing to delay starting glyph order 🤦. Edit: correction, it's still about the same time, it's just not moving earlier. I'll dig into that but I think this is worth landing regardless.
|
anthrotype
approved these changes
Nov 14, 2023
cmyr
reviewed
Nov 14, 2023
Add a few things to timing output to make it more helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I can also migrate some of the work in glyph order out of it to avoid having it block the world.
Before, glyph order blocks all be work:
After, some be (blue) work can happen before glyph order:
Hopefully part of a series leading to improvements wrt #456.