Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push building a lookup up one level #560

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Push building a lookup up one level #560

merged 1 commit into from
Nov 10, 2023

Conversation

rsheeter
Copy link
Contributor

@rsheeter rsheeter commented Nov 10, 2023 •
edited
Loading

We used to produce a lookup per base (ty @cmyr for noticing!) which isn't quite right.

@rsheeter rsheeter changed the title Push building a lookup out one level Push building a lookup up one level Nov 10, 2023
cmyr
cmyr approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Also afaik this was the cause of #559, although I'm confused about why that was the case and am going to dig a bit more into that and try to identify the root cause.

@rsheeter rsheeter added this pull request to the merge queue Nov 10, 2023
Merged via the queue into main with commit 34e2e2f Nov 10, 2023
9 checks passed
@rsheeter rsheeter deleted the merk branch November 10, 2023 16:44
@rsheeter rsheeter mentioned this pull request Nov 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsheeter @cmyr