Skip to content
This repository was archived by the owner on Sep 2, 2023. It is now read-only.

[Dispatcher] Feature: choose (or be smart about picking) "before" family diff files. #120

Closed
graphicore opened this issue Aug 28, 2019 · 1 comment

Comments

@graphicore
Copy link
Contributor

Currently, the family "Solway" is in google/fonts master git but not available via the google fonts production api (gives "Page not found" at the moment)

Despite of the bad handling of the actual error (see #119) this leaves some questions to consider:

  • We may want to choose other diff "before" sources than the Google Fonts API, e.g. the GitHub google/fonts:master or in a (sandboxed? [see Feature: Sandboxed workflow #117]) feature branch workflow maybe another repository/branch to compare to.
  • For production google/fonts:mastercould take precedence over the production API if the version in master is newer.
  • Should we (and can we actually) also consider the Google Fonts Sandbox API?

Also: DiffBrowsers task should show just previews in this case, just opened #118

graphicore added a commit that referenced this issue Sep 13, 2019
…120

 Also: WIP sandbox mode; make sources selectable for diffing tasks.
graphicore added a commit that referenced this issue Sep 24, 2019
…120

 Also: WIP sandbox mode; make sources selectable for diffing tasks.
@graphicore
Copy link
Contributor Author

Fixed in 62d5a14

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant