Skip to content
This repository was archived by the owner on Sep 2, 2023. It is now read-only.

[Dispatcher] DiffbrowsersTask and PreviewsTask should be the same. #118

Closed
graphicore opened this issue Aug 28, 2019 · 1 comment
Closed

[Dispatcher] DiffbrowsersTask and PreviewsTask should be the same. #118

graphicore opened this issue Aug 28, 2019 · 1 comment

Comments

@graphicore
Copy link
Contributor

As well as the python workers diffbrowsers and previews.

  • They use the same tool and mostly similar code.
  • A family may have new fonts e.g. newly added weights and should therefore have previews for new fonts and the full diffs for updated/existing fonts.
  • Thus, a completely new family without any existing "before" fonts should produce just previews with the same tool.
This was referenced Aug 28, 2019
Closed
Closed
@graphicore
Copy link
Contributor Author

Related: #119 and #120, both would benefit from this.

This is also a good maintenance effort as it reduces lines of code and very similar code.

graphicore added a commit that referenced this issue Sep 13, 2019
@graphicore
[Dispatcher] merge previews and diffbrowsers task; Fixes #118, #119, #…
8c91ce9 
…120

 Also: WIP sandbox mode; make sources selectable for diffing tasks.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@graphicore