[skrifa] tthint: graphics state #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First of a series of TrueType hinting patches. This one models the TT "graphics state" which is essentially all of the data involving outlines, measurement and rounding. Includes a tiny math module that provides support for working with fixed point values as raw i32s. This is not ideal but exists from the initial port from FreeType and will require some time and attention to correct. This will need to be deferred to a later time.
rsheeter
reviewed
Jan 22, 2024
| } | ||
|
|
||
| impl Default for RetainedGraphicsState { | ||
| fn default() -> Self { |
There was a problem hiding this comment.
Is there a reference for where the defaults came from?
There was a problem hiding this comment.
Added links to graphics state summary table in the spec which lists the default values.
rsheeter
reviewed
Jan 22, 2024
| (Wrapping(u.0 as i32) * sx / Wrapping(4)).0, | ||
| (Wrapping(v.0 as i32) * sy / Wrapping(4)).0, | ||
| ) | ||
| } |
There was a problem hiding this comment.
Some of these seems complex enough to warrant testing
There was a problem hiding this comment.
The normalize function is particularly nasty :/ Added test cases for mul_div_no_round, mul14 and normalize14 with values generated by their respective FT functions. These also include sanity checks that compute the result in floating point and test with a tolerance.
rsheeter
approved these changes
Jan 22, 2024
- add links to table containing default values for graphics state - add tests for new fixed point math functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of a series of TrueType hinting patches.
This one models the TT "graphics state" which is essentially all of the data involving outlines, measurement and rounding.
Includes a tiny math module that provides support for working with fixed point values as raw i32s. This is not ideal but exists from the initial port from FreeType and will require some time and attention to correct. This will need to be deferred to a later time.