Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[write-fonts/gvar] Fix shared tuples unstable order #756

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

anthrotype
Copy link
Member

@anthrotype anthrotype commented Jan 15, 2024

@anthrotype
Copy link
Member Author

https://github.com/googlefonts/fontations/actions/runs/7528580955/job/20491085359?pr=756

failures:

---- tables::gvar::tests::shared_tuples_stable_order stdout ----
thread 'tables::gvar::tests::shared_tuples_stable_order' panicked at write-fonts/src/tables/gvar.rs:1270:13:
assertion `left == right` failed
  left: [[-1.0], [1.0]]
 right: [[1.0], [-1.0]]

@anthrotype anthrotype changed the title [write-fonts/gvar] repro shared tuples unstable order [write-fonts/gvar] Fix shared tuples unstable order Jan 15, 2024
@anthrotype
Copy link
Member Author

I can confirm this enables reproducible builds for Oswald. I tested rebuilding a hundred times and fontc always produces exact same bytes for gvar, previously it would fail about 50% of the times.

Copy link
Member

@dfrg dfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a reasonable fix to me, thanks!

@anthrotype anthrotype merged commit e032597 into main Jan 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repeated builds are not deterministic
2 participants