[Skrifa] Avoid initialization of HashSet with system random numbers #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested in Chromium, works as a solution for https://bugs.chromium.org/p/chromium/issues/detail?id=1516634. |
cmyr
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Okay this makes sense.
My one concern here is that it would be easy for someone to introduce other uses of hashmap without being aware that it will break the upstream client? But I can't think of any clean way to prevent that, so I guess it will be a matter for code review.
And just as an observation, if this was a pattern we were doing a lot I might create a trait, DeterministicHash, where we could define a constructor method, so you could just call, HashSet::new_non_random() or something. Definitely not necessary, just mentioning it because it's a useful pattern to consider sometimes.
Workaround for [1] and [2] - issues in the Chrome sandbox requiring access to random number generators. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1516634 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=1516641
vigneshvg
added a commit
to webmproject/CrabbyAvif
that referenced
this pull request
Jan 31, 2024
And add workaroud to use non random state for chrome on windows. Based on googlefonts/fontations#751.
drott
added a commit
to drott/fontations
that referenced
this pull request
Mar 11, 2024
…umbers (googlefonts#751)" This reverts commit eef6a26. See details in [1] and [2]. Rust upstream landed a change switching to a different, sandbox-compatible call for PRNG, except on Windows 7. Windows 7 is no longer supported by Chromium. Chromium is our only known sandboxed environment where this call would fail. Remove the workaround. [1] https://issues.chromium.org/40277768 [2] rust-lang/rust@08caefb
drott
added a commit
that referenced
this pull request
Mar 11, 2024
…umbers (#751)" (#825) This reverts commit eef6a26. See details in [1] and [2]. Rust upstream landed a change switching to a different, sandbox-compatible call for PRNG, except on Windows 7. Windows 7 is no longer supported by Chromium. Chromium is our only known sandboxed environment where this call would fail. Remove the workaround. [1] https://issues.chromium.org/40277768 [2] rust-lang/rust@08caefb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for [1] and [2] - issues in the Chrome sandbox requiring access to random number generators.
[1] https://bugs.chromium.org/p/chromium/issues/detail?id=1516634
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=1516641