[skrifa] return overlap status from scaler #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step in addressing #581. Captures simple and composite overlap bits and plumbs them through internally. Still needs to be exposed in skrifa public API. This will be done in a follow up.
rsheeter
reviewed
Aug 24, 2023
skrifa/src/scale/mod.rs
Outdated
| // GID 2 is a composite glyph with the overlap bit on a component | ||
| // GID 3 is a simple glyph with the overlap bit on the first flag | ||
| assert_eq!(metrics.has_overlaps, gid == 2 || gid == 3); | ||
| } |
There was a problem hiding this comment.
Same preference for how to assert this as #582
rsheeter
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Scaler::outlineto return a newScalerMetricsstruct that contains the overlap flag. This also has optional fields to represent metrics that may be adjusted by hinting.Based on #582 which must be merged first.
Fixes #581