Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Skrifa] Fix panic in degenerate linear gradient drawing #1206

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

drott
Copy link
Contributor

@drott drott commented Oct 28, 2024

Avoid a panic when a degenerate linear gradient occurs and an empty color line is passed.

Fixes #1205.

Avoid a panic when a degenerate linear gradient occurs and an empty
color line is passed.

Fixes googlefonts#1205.
Copy link
Member

@dfrg dfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should file an issue for reducing the test case. We had a problem recently where fuzzer generated fonts happened to depend on implementation defined behavior in std and our tests broke when that behavior changed.

@drott
Copy link
Contributor Author

drott commented Oct 28, 2024

Filed as #1207

@drott drott merged commit 24d25a1 into googlefonts:main Oct 28, 2024
8 checks passed
dfrg pushed a commit that referenced this pull request Dec 12, 2024
Avoid a panic when a degenerate linear gradient occurs and an empty
color line is passed.

Fixes #1205.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic in COLRv1 with degenerate linear gradient
2 participants