Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skrifa] use hdmx table if available #1165

Merged
merged 1 commit into from
Oct 2, 2024
Merged

[skrifa] use hdmx table if available #1165

merged 1 commit into from
Oct 2, 2024

Conversation

dfrg
Copy link
Member

@dfrg dfrg commented Oct 1, 2024

In ScaledOutline::adjusted_advance_width() prefer widths from hdmx over phantom points to better match FreeType.

In `ScaledOutline::adjusted_advance_width()` prefer widths from `hdmx` over phantom points to better match FreeType.
Copy link
Contributor

@drott drott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this would benefit from a test, but in the interest of getting this into a release, I am okay with doing this in a follow-up. This will have some coverage in Chromium's web tests.

@dfrg
Copy link
Member Author

dfrg commented Oct 2, 2024

I'll add tests for adjusted advance width in fauntlet after I address the problem with empty glyphs. I can also add a unit test when I find a font with an hdmx table that has known provenance.

@dfrg dfrg merged commit bbc62a6 into main Oct 2, 2024
10 checks passed
@dfrg dfrg deleted the skrifa-hdmx branch October 2, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants