Skip to content
This repository has been archived by the owner on Jun 16, 2019. It is now read-only.

Adding support for css class styling. #111

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from

Conversation

KevinJCandlert
Copy link

I wanted a way to get custom styling from CSS instead of having repeatedly inline CSS for each cluster marker.
If the cssClass options are supplied it will ignore the default styling and the options from the 'styles' parameter.

This is more or less the same feature as #24 but with less white-space changes and different implementation.

Kevin Candlert added 3 commits November 25, 2016 12:54
…tom css is supplied it will ignore the default style and the 'styles' parameter.
…tom css is supplied it will ignore the default style and the 'styles' parameter.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@KevinJCandlert
Copy link
Author

I signed it!

@Remo
Copy link
Contributor

Remo commented Dec 23, 2016

@KevinJCandlert google doesn't support this anymore, but we've created a fork where you can find this option https://gmaps-marker-clusterer.github.io/gmaps-marker-clusterer/#reference-styles

@KevinJCandlert
Copy link
Author

KevinJCandlert commented Dec 23, 2016

@Remo Yeah, I've noticed that. But I couldn't find which branch you've merged.
I'm not entirely satisfied with my own merge request - As it ignores all the other styling options.

But just adding a CSS class to the cluster-marker along with all the inline styling requires you to add !important to all your CSS-attributes.

It's hard to get it right and also maintain some kind of good UX for the API 👍

@Remo
Copy link
Contributor

Remo commented Dec 23, 2016

I think there were two branches, this should be the one that was merged (not by me) https://github.com/gmaps-marker-clusterer/gmaps-marker-clusterer/pull/6/files

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants