grpc: create new ComputeEngineCredentials via newBuilder. #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmehta19
changed the title
rockspore
reviewed
Feb 22, 2025
| @@ -1199,14 +1199,18 @@ boolean isDirectPathBoundTokenEnabled() { | |||
| CallCredentials createHardBoundTokensCallCredentials( | |||
| ComputeEngineCredentials.GoogleAuthTransport googleAuthTransport, | |||
| ComputeEngineCredentials.BindingEnforcement bindingEnforcement) { | |||
| ComputeEngineCredentials.Builder credsBuilder = | |||
| ((ComputeEngineCredentials) credentials).toBuilder(); | |||
| // We only set scopes and HTTP transport factory from the original credentials because | |||
There was a problem hiding this comment.
For future readers, could you explain briefly in the comment why we create it from a newBuilder()?
product-auto-label
bot
added
size: xs
product-auto-label
bot
added
size: s
rmehta19
changed the title
|
@lqiu96 , please review, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rockspore pointed out that the credential should be created from scratch because when using toBuilder the underlying access token is copied.
This was confirmed to be a bug with local testing which:
allowedHardBoundAccessTokensempty in GrpcProvider) and then ping the API, logs show the bearer token is used, obtained from making call to MDSallowedHardBoundAccessTokenscontainsMTLS_S2Ain GrpcProvider) and then ping the API, logs show the bearer token is used. A call to MDS is not made.This is likely because the credential and channel have different lifetimes.