Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): sync client verification tests #1046

Merged
merged 419 commits into from
Dec 18, 2024
Merged

chore(tests): sync client verification tests #1046

merged 419 commits into from
Dec 18, 2024

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Nov 28, 2024 •
edited
Loading

Blocked on #1017

This PR adds two new tests to verify the new sync outputs:

  • the conformance test is updated to run against the new sync client
  • there's a new unit test to verify that the generated code is up to date

@daniel-sanche
refactor outputs
eb5cd48
@daniel-sanche
renamed artifact class; added comments
e5a8792
@daniel-sanche
added back conversion annotations
39ae907 
This reverts commit 245bd08.
@daniel-sanche
Merge branch 'cross_sync_pr1_replacements' into cross_sync_pr2_genera…
d17a98c 
…tors
@daniel-sanche
fixed decorator sync_impl call
fd1fb71
@daniel-sanche
Merge branch 'cross_sync_pr1_replacements' into cross_sync_pr2_genera…
c0b4185 
…tors
@daniel-sanche
use add_mapping in place of replace_symbols
adb092e
@daniel-sanche
support automatic attribute registration
45efa16
@daniel-sanche
reduced replace_symbols usage in tests
e1ec974
@daniel-sanche
fixed lint issues
021fde2
@daniel-sanche
Merge branch 'cross_sync_pr1_replacements' into cross_sync_pr2_genera…
58405d1 
…tors
@daniel-sanche
added missing imports
de0fd90
@daniel-sanche
get mappings working for sync implementation
6ca3ddd
@daniel-sanche
moved decorators into new file
b2cf937
@daniel-sanche
moved transformation from transformers into decorators
4860061
@daniel-sanche
simplified arguments for decorators
63891d7
@daniel-sanche
use separate decorate method
164f5a8
@daniel-sanche
comments and clean up
8317973
@daniel-sanche
ran blacken
f9dd41d
@daniel-sanche
moved ast decorators into new file
22b093f
@daniel-sanche
Merge branch 'cross_sync_pr1_replacements' into cross_sync_pr2_genera…
5ebf889 
…tors
@daniel-sanche
ran blacken
8d13c5e
@daniel-sanche
Merge branch 'cross_sync_pr1_replacements' into cross_sync_pr2_genera…
ea8072f 
…tors
@daniel-sanche
changed sync impl name
769cac1
@daniel-sanche
fixed mapping function
f87b832
@daniel-sanche
convert to async with pytest mark
f2b6d08
@daniel-sanche
Merge branch 'cross_sync_pr1_replacements' into cross_sync_pr2_genera…
754adf8 
…tors
@daniel-sanche
convert changes async to sync def by default
3ed5935
@daniel-sanche
added rm_aio for stripping asyncio keywords
d0ba7b0
@daniel-sanche
reverted client and test changes
37b4833
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/python-bigtable API. labels Nov 28, 2024
@daniel-sanche daniel-sanche mentioned this pull request Nov 28, 2024
Merged
Base automatically changed from cross_sync2_pr3_generated_sync to main December 12, 2024 21:41
@daniel-sanche daniel-sanche marked this pull request as ready for review December 12, 2024 22:18
@daniel-sanche daniel-sanche requested review from a team as code owners December 12, 2024 22:18
@daniel-sanche daniel-sanche assigned mutianf and unassigned sushanb Dec 12, 2024
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2024
@daniel-sanche daniel-sanche added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 16, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 16, 2024
mutianf
mutianf approved these changes Dec 17, 2024
View reviewed changes
.github/workflows/conformance.yaml Outdated Show resolved Hide resolved
.github/workflows/conformance.yaml
- client-type: "sync"
# sync client does not support concurrent streams
test_args: "-skip _Generic_MultiStream"
- client-type: "legacy"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im wondering if we could remove this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah for sure, I opened #1054 to track this

@daniel-sanche @mutianf
fix typo
710190b 
Co-authored-by: Mattie Fu <[email protected]>
@daniel-sanche daniel-sanche mentioned this pull request Dec 18, 2024
Open
@daniel-sanche daniel-sanche merged commit 7a6d0c5 into main Dec 18, 2024
31 of 33 checks passed
@daniel-sanche daniel-sanche deleted the cross_sync2_pr4_tests branch December 18, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutianf mutianf mutianf approved these changes

Assignees

@mutianf mutianf

Labels
api: bigtable Issues related to the googleapis/python-bigtable API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daniel-sanche @mutianf @sushanb @yoshi-kokoro