Code

fix: Fixes number autoconversion#941

Code

Open

danieljbruce wants to merge 37 commits intogoogleapis:maingoogleapis/nodejs-datastore:mainfrom danieljbruce:fixNumberAutoconversiondanieljbruce/nodejs-datastore:fixNumberAutoconversionCopy head branch name to clipboard

+370-72

Commits

Commits on Dec 8, 2020

• fix: discontinue auto-conversion of JavaScript Numbers to datastore types

  crwilcox

  committed
  28c2327

  Copy full SHA for 28c2327

• fix!:add a warning when a number is autoconverted to double or int

  crwilcox

  committed
  8a5aba8

  Copy full SHA for 8a5aba8

• chore: gts fix

  crwilcox

  committed
  068b0bf

  Copy full SHA for 068b0bf

• fix: modify warnings to be phrased better

  crwilcox

  committed
  a7152f5

  Copy full SHA for a7152f5

• fix: process.once to avoid debouncing type issues

  crwilcox

  committed
  b125553

  Copy full SHA for b125553

• fix: debounce warning of typing to occur only once

  crwilcox

  committed
  2d31c03

  Copy full SHA for 2d31c03

Commits on Dec 9, 2020

• chore: gts fix

  crwilcox

  committed
  5b62746

  Copy full SHA for 5b62746

• chore: don't use it.only

  crwilcox

  committed
  39e618c

  Copy full SHA for 39e618c

• test: add test to verify typecast warning is debounced

  crwilcox

  committed
  573880d

  Copy full SHA for 573880d

Commits on Dec 10, 2020

• fix: errant console log committed

  crwilcox

  committed
  a2ba674

  Copy full SHA for a2ba674

• test: alter expected properties to match property

  crwilcox

  committed
  beab398

  Copy full SHA for beab398

• test: add test that captures current, not desired, behavior

  crwilcox

  committed
  aa86a2f

  Copy full SHA for aa86a2f

Commits on Dec 11, 2020

• feat!: do not automatically unwrap numbers for users, though allow them to specify it

  crwilcox

  committed
  1d80aea

  Copy full SHA for 1d80aea

• test: modify test to capture now current wrap behavior. other tests need altering still

  crwilcox

  committed
  b2f4e4d

  Copy full SHA for b2f4e4d

• feat: extend Number on Double class

  crwilcox

  committed
  3c6eb03

  Copy full SHA for 3c6eb03

• test: fix system tests

  crwilcox

  committed
  62f4f3e

  Copy full SHA for 62f4f3e

Commits on Dec 12, 2020

• test: fix unit tests, revert to using number for storing value of double

  crwilcox

  committed
  2085357

  Copy full SHA for 2085357

• test: fix system test for number/double string/number change.

  crwilcox

  committed
  b28df5f

  Copy full SHA for b28df5f

Commits on May 3, 2022

• tests for wrapping ints

  danieljbruce

  committed
  1713a9a

  Copy full SHA for 1713a9a

• Double values test

  danieljbruce

  committed
  b32d3cc

  Copy full SHA for b32d3cc

• nit: clarify comment

  danieljbruce

  committed
  5e1b0f8

  Copy full SHA for 5e1b0f8

Commits on May 4, 2022

• Remove dependency.

  danieljbruce

  committed
  dd9e711

  Copy full SHA for dd9e711

Commits on May 5, 2022

• Add a test to ensure that doubles are received

  danieljbruce

  committed
  e01fec0

  Copy full SHA for e01fec0

• Added more tests for Double

  danieljbruce

  committed
  8aa7c31

  Copy full SHA for 8aa7c31

• remove repeated code fragment

  danieljbruce

  committed
  4d15a47

  Copy full SHA for 4d15a47

• Changed warning message

  danieljbruce

  committed
  8dc7b62

  Copy full SHA for 8dc7b62

Commits on May 6, 2022

• linting fix

  danieljbruce

  committed
  d6eff51

  Copy full SHA for d6eff51

• Merge branch 'main' of https://github.com/googleapis/nodejs-datastore into fixNumberAutoconversion

  Show description for 70de408
  danieljbruce

  committed
  70de408

  Copy full SHA for 70de408

Commits on May 9, 2022

• Remove file

  danieljbruce

  committed
  074d218

  Copy full SHA for 074d218

• Attempts to fix sample test

  danieljbruce

  committed
  1bf4254

  Copy full SHA for 1bf4254

• Linting fix

  danieljbruce

  committed
  2cdf4c5

  Copy full SHA for 2cdf4c5

• Updates for sample test

  danieljbruce

  committed
  6044901

  Copy full SHA for 6044901

• Fix the datastore int constructions

  danieljbruce

  committed
  4f0c8b4

  Copy full SHA for 4f0c8b4

• linting fix

  danieljbruce

  committed
  85ae2cc

  Copy full SHA for 85ae2cc

• before and after balance

  danieljbruce

  committed
  56733e7

  Copy full SHA for 56733e7

Commits on May 10, 2022

• use deep strict equal

  danieljbruce

  committed
  80b993b

  Copy full SHA for 80b993b

• Fix sample

  danieljbruce

  committed
  9371dcb

  Copy full SHA for 9371dcb