Skip to content

chore!: migrate to Node 18 #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
May 1, 2025
Merged

chore!: migrate to Node 18 #1384

merged 38 commits into from
May 1, 2025
+2,335 −1,768

Conversation

danieljbruce
Copy link
Contributor

@danieljbruce danieljbruce commented Apr 30, 2025 •
edited
Loading

This PR is the PR with the fixes necessary for upgrading to Node 18. Changes include:

  • Fixing promise linting errors
  • Addressing a bug caused by protobufjs
  • Addressing arrify errors
  • Addressing other linting errors

gcf-owl-bot bot and others added 29 commits May 20, 2024 16:53
@gcf-owl-bot
feat: New PropertyMask field which allows partial commits, lookups, a…
8c1128f 
…nd query results

PiperOrigin-RevId: 635449160

Source-Link: googleapis/googleapis@dde0ec1

Source-Link: googleapis/googleapis-gen@8caa60d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGNhYTYwZDlhZWE4Mjk2NGExOWNkZjhmYWY5MTM4NDkxMWRiOGJkZCJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
9b913b4 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
chore: remove redundant gRPC service config file
3cddaf8 
feat: specify retry configuration

PiperOrigin-RevId: 712493958

Source-Link: googleapis/googleapis@29aea41

Source-Link: googleapis/googleapis-gen@04bcbab
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDRiY2JhYjQ1MDU5ODllOTg0YjE0MDNkNDM4ZmZmYzAzMTIxNDRhZiJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
db2a806 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
feat: paging changes for bigquery
cc25c93 
fix: add x-goog-request params to headers for LRO-polling methods
fix: remove extra protos in ESM & capture ESM in headers
docs: update comments for a Nodejs stream object

PiperOrigin-RevId: 721038181

Source-Link: googleapis/googleapis@331a41a

Source-Link: googleapis/googleapis-gen@e81b4c5
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTgxYjRjNWI1MjA4ODk1ZjY2M2EyNDA0ODYxNWE1OWQ1NjM2ZjQxNSJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
4f8a6aa 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
fix: fix typings for headers in generator
449c4db 
PiperOrigin-RevId: 723181578

Source-Link: googleapis/googleapis@c7b69f4

Source-Link: googleapis/googleapis-gen@d1bc1ac
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDFiYzFhY2Q3NDI5NjQyMmE1Y2I2ZTBjNDAxNmM4YzQ4ZTk5ODUzOCJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
5ddd027 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
fix: finalize fixing typings for headers in generator
d1268a9 
PiperOrigin-RevId: 723563760

Source-Link: googleapis/googleapis@2f843e2

Source-Link: googleapis/googleapis-gen@cd0f9c6
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2QwZjljNmZlMWRkNzdjNTUyZWY3NjZlNjA0N2Y4ZGNmZDNiY2MyZSJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
27f64ae 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
chore: update copyright year for auto-generated protos
c8c8fa2 
PiperOrigin-RevId: 731738802

Source-Link: googleapis/googleapis@d72ca0d

Source-Link: googleapis/googleapis-gen@2734992
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjczNDk5MjBkYWU2Y2Q0YzJhNTFjMWM1YjRiNDNlMmMwMGYwMjk2NiJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
89baa37 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
chore: update copyright year for auto-generated protos
156820c 
PiperOrigin-RevId: 732130682

Source-Link: googleapis/googleapis@9415ba0

Source-Link: googleapis/googleapis-gen@2905f83
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjkwNWY4MzM3NTZjMmIyMGIzMjgyYmU4NGI1MTFlMDQwZmU1NGYzMyJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
92f058e 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
chore: update typescript gapic generator to 4.8.1
538f211 
feat: add request/response debug logging to gapics, update templates to gax 5 and node 18 (#1671)
fix: add json files to tsconfig templates (#1692) (ba6be1d)

PiperOrigin-RevId: 735896588

Source-Link: googleapis/googleapis@3419af7

Source-Link: googleapis/googleapis-gen@f35ba11
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjM1YmExMTQyZjRlMTY4MjIyMzI3ZDg5MmI1ZjZlZTkwOGU1ZDQ2MSJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
4984170 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
feat: await/catch promises, and update listOperationsAsync return type
8297d8b 
PiperOrigin-RevId: 738212310

Source-Link: googleapis/googleapis@803b234

Source-Link: googleapis/googleapis-gen@4f44bd2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
369f238 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@danieljbruce
Merge branch 'main' into owl-bot-copy
af2ef87
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
bf87f1f 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@danieljbruce
Merge branch 'owl-bot-copy' of https://github.com/googleapis/nodejs-d…
1391a92 
…atastore into owl-bot-copy

# Conflicts:
#	protos/google/datastore/v1/datastore.proto
#	protos/protos.d.ts
#	protos/protos.js
#	protos/protos.json
@danieljbruce
Resolve the linting errors
0a41dce
@danieljbruce
Run the migration script
d60134b
@danieljbruce
Delete the migration script
db31c83
@danieljbruce
Add files to include in compilation
c650aa4
@danieljbruce
Cherry picking
c2d88da
@danieljbruce
Add void in front of a bunch of promises
a973991
@danieljbruce
Downgrade arrify
62a46b4
@danieljbruce
Downgrade protobufjs
3897575
@danieljbruce danieljbruce requested a review from a team as a code owner April 30, 2025 15:04
@danieljbruce danieljbruce requested a review from a team as a code owner April 30, 2025 15:04
@generated-files-bot Generated Files Bot
Copy link

generated-files-bot bot commented Apr 30, 2025 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node14/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node14/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node14/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node14/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node14/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node14/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node14/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node14/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node14/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/samples-test.sh - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: datastore Issues related to the googleapis/nodejs-datastore API. labels Apr 30, 2025
@danieljbruce danieljbruce changed the title test: Owl bot copy linting node 18 2 migrate chore!: migrate to Node 18 Apr 30, 2025
@danieljbruce danieljbruce added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2025
@danieljbruce danieljbruce added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2025
@danieljbruce danieljbruce added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2025
@sofisl
Copy link
Contributor

sofisl commented May 1, 2025

LGTM, but I would improve the PR message if anyone needs to see what was actually changed, for example, catching promises, etc.

@danieljbruce danieljbruce merged commit 43c3472 into main May 1, 2025
17 of 18 checks passed
@danieljbruce danieljbruce deleted the owl-bot-copy-linting-node-18-2-migrate branch May 1, 2025 20:58
@release-please release-please bot mentioned this pull request Apr 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofisl sofisl sofisl approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/nodejs-datastore API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieljbruce @sofisl @yoshi-kokoro