Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add comment that pagination happens automatically #1427

Merged
merged 2 commits into from
Nov 14, 2024
Merged

docs: add comment that pagination happens automatically #1427

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ab74a9
docs: add comment that pagination happens automatically
alvarowolfx Nov 12, 2024
53568df
docs: improve comment around pagination
alvarowolfx Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions samples/queryPagination.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ function main() {
const [job] = await bigquery.createQueryJob(query);

// Wait for job to complete and get rows.
// The client library automatically handles pagination.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// The client library automatically handles pagination.
// The client library automatically handles pagination.
// See more info at https://github.com/googleapis/gax-nodejs/blob/main/client-libraries.md#auto-pagination for more information on how to configure paging calls

// See more info on how to configure paging calls at:
// * https://github.com/googleapis/gax-nodejs/blob/main/client-libraries.md#auto-pagination
// * https://cloud.google.com/bigquery/docs/paging-results#iterate_through_client_libraries_results
const [rows] = await job.getQueryResults();

console.log('Query results:');
Expand Down
Loading