Skip to content

Commit

Permalink
fix: lint issues
Browse files Browse the repository at this point in the history
  • Loading branch information
alvarowolfx committed May 31, 2024
1 parent 4598bc3 commit 652e802
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
10 changes: 7 additions & 3 deletions src/bigquery.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2198,7 +2198,11 @@ export class BigQuery extends Service {
if (res && res.jobComplete) {
if (job && res.pageToken && this._storageClient) {
try {
const rows = await this.acceleratedFetchDataFromJob_(job, options, res.schema);
const rows = await this.acceleratedFetchDataFromJob_(
job,
options,
res.schema
);
(callback as QueryRowsCallback)(null, rows, null);
return;
} catch (err) {
Expand Down Expand Up @@ -2234,12 +2238,12 @@ export class BigQuery extends Service {
private async acceleratedFetchDataFromJob_(
job: Job,
opts: QueryOptions,
schema?: bigquery.ITableSchema,
schema?: bigquery.ITableSchema
): Promise<any[]> {
if (!this._storageClient) {
return Promise.reject('storage client not available');
}
console.time('fetchMetadata');
console.time('fetchMetadata');
const [metadata] = (await job.getMetadata()) as bigquery.IJob[];

Check warning on line 2247 in src/bigquery.ts

View workflow job for this annotation

GitHub Actions / lint

Unexpected any. Specify a different type
this.trace_('[job metadata]', metadata.configuration?.query);
const qconfig = metadata.configuration?.query;
Expand Down
4 changes: 2 additions & 2 deletions src/storage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ import {Transform} from 'stream';
import {BigQuery, QueryRowsResponse, RowMetadata} from '.';
import bigquery from './types';

// Minimal interface for a BigQuery Storage Read API client
// Minimal interface for a BigQuery Storage Read API client
// that can read data from tables.
export interface StorageReadClient {
createTableReader(req: {
table: bigquery.ITableReference;
}): Promise<TableReader>;
}

// Interface for fetching data from a BigQuery table using
// Interface for fetching data from a BigQuery table using
// the BigQuery Storage Read API.
export interface TableReader {
getRows(): Promise<QueryRowsResponse>;
Expand Down

0 comments on commit 652e802

Please sign in to comment.