[DO NOT MERGE | POC] feat: Adding support for UUID type #3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
| @@ -94,6 +94,9 @@ private Object writeReplace() { | |||
| case PG_NUMERIC: | |||
| builder.set(fieldName).to((String) value); | |||
| break; | |||
| case UUID: | |||
| builder.set(fieldName).to((String) value); | |||
There was a problem hiding this comment.
I think this value is from backend as string. Should we be using fromString to convert string value to java.util.UUID value? I don't think this is the right place to do this conversion. May be when customer reads it as UUID then we should use the fromString method.
https://docs.oracle.com/javase/8/docs/api/java/util/UUID.html
| @@ -287,6 +296,7 @@ public enum Code { | |||
| FLOAT64(TypeCode.FLOAT64, "double precision"), | |||
| FLOAT32(TypeCode.FLOAT32, "real"), | |||
| STRING(TypeCode.STRING, "character varying"), | |||
| UUID(TypeCode.STRING, "uuid"), | |||
There was a problem hiding this comment.
As per design doc a new TypeCode UUID will be added. This will recognize the input serialized string value as UUID in backend to store it appropriately.
Suggested change
| UUID(TypeCode.STRING, "uuid"), | |
| UUID(TypeCode.UUID, "uuid"), |
gauravpurohit06
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Adding support for uuid type.